Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete highlighting for keywords of SQLite SQL statement #420

Closed
renkun-ken opened this issue Feb 19, 2014 · 1 comment
Closed

Incomplete highlighting for keywords of SQLite SQL statement #420

renkun-ken opened this issue Feb 19, 2014 · 1 comment
Labels

Comments

@renkun-ken
Copy link

Suppose a SQL statement for SQLite is as follows:

SELECT *, price * volume AS totalValue 
FROM df 
WHERE price >= (SELECT AVG(price) FROM df)
ORDER BY totalValue DESC
LIMIT 100

highlight.js correctly highlights ordinary keywords in SQL standard except for LIMIT keyword for SQLite. Some other keywords in SQL-dialects are not supported either. Is there any possibility to support major SQL-dialects?

@Sannis Sannis added the bug label Feb 20, 2014
@isagalaev
Copy link
Member

Sorry for taking so long to reply to this. By this time "LIMIT" is there and highlights properly. And we certainly can accept more keywords for SQL dialects. The best way to do this is to submit them as a pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants