Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopscotch version bump to 1.0.1 #917

Merged
merged 1 commit into from Aug 25, 2015
Merged

Hopscotch version bump to 1.0.1 #917

merged 1 commit into from Aug 25, 2015

Conversation

idleberg
Copy link
Contributor

No description provided.

@Sannis
Copy link
Collaborator

Sannis commented Aug 25, 2015

Oh, this PR title was scare me :-)

@Sannis Sannis added this to the 8.8 milestone Aug 25, 2015
@Sannis Sannis self-assigned this Aug 25, 2015
@Sannis Sannis changed the title version bump to 1.0.1 Hopscotch version bump to 1.0.1 Aug 25, 2015
Sannis added a commit that referenced this pull request Aug 25, 2015
Hopscotch version bump to 1.0.1
@Sannis Sannis merged commit 2b6a3ca into highlightjs:master Aug 25, 2015
@isagalaev
Copy link
Member

Uhm… Sorry, looks like I'll have to ruin it all and revert the patch. We deliberately don't include all this stuff in our styles to keep them consistent with each other (jumping fonts and text measurements on style switching look ugly) and to not impose the choice of fonts on users. Of all these changes, probably only direction: ltr does make sense, but it should go in every style then, not just one.

On a related note: the new-styles branch is nearing completion so now it makes sense to do any style updates against that branch instead of master.

@idleberg
Copy link
Contributor Author

Ah, I thought of the possibility, but then I saw the CodePen theme using a different font as well. Nevermind, if that's policy that's fine.

@isagalaev
Copy link
Member

I saw the CodePen theme using a different font as well

I fully admit I wasn't very diligent in keeping them all in check :-). The new-styles is going to bring a lot of unification and I'll fix those common rules for every style too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants