Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing full OSS license #107

Closed
filiph opened this issue Oct 26, 2019 · 2 comments
Closed

Consider providing full OSS license #107

filiph opened this issue Oct 26, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@filiph
Copy link

filiph commented Oct 26, 2019

I am not a lawyer, so take everything here with a grain of salt.

I was a bit worried when I saw that GitHub doesn't autodetect the OSS license of this project. It does link to the LICENSE file, but only says "see license".

Screen Shot 2019-10-25 at 7 27 12 PM

I'd rather like to see:

Screen Shot 2019-10-25 at 7 27 28 PM

From what I understand from the legalese at https://www.apache.org/licenses/LICENSE-2.0, I think you're not doing anything wrong, technically, by showing only the short text. But I, for one, would feel better if GitHub just automatically said the project is Apache 2.0, like it does for many other OSS projects.

See https://github.com/moby/moby/blob/master/LICENSE for an example how to include the full license.

Screen Shot 2019-10-25 at 7 27 01 PM

@filiph filiph added the bug Something isn't working label Oct 26, 2019
@simc
Copy link
Member

simc commented Oct 26, 2019

Initially I used the long version but the Flutter showLicensePage() method did not like it #34.

I'm sure it makes not difference whether the full license is included but I'll change that.

@simc
Copy link
Member

simc commented Oct 26, 2019

Done.

@simc simc closed this as completed Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants