New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address insufficient contrast of white text over grey background: 0.5 #251
Comments
This is live on staging (whenever it's back online) |
I do think this needs a better focus indicator. Perhaps adding |
Desired contrast goals achieved. I agree with @alecpm about focus/hover; I'll create a new ticket for that and let's hold this one as blocked until that other ticket has been implemented and reviewed. |
@alecpm Actually, we've lost the section-specific background colors for "graduate studies," "visiting scholars," "events," and "exhibitions" (compare to production). The gray background color (which is now universal on staging) is meant only to apply to sections that are not those "colorful four". |
I commented out the special color sections because they seemed to have some contrast issues with the new text color. I can bring them back. I'd suggest we consider switching to white text for those (at least for the brick and "graduate studies" colors). |
Yes, I'm sorry I wasn't clearer earlier. I didn't see any need to change the text color for the special-color sections; their contrast numbers were fine. This ticket should have been constrained only to breadcrumbs that were making use of the gray background. |
This is fixed on staging. |
Looks good. Please merge to master and deploy to production. |
e.g., in breadcrumbs for people sections.
Traceability: Microassist Report 1 > WCAG Compliance > Color Contrast
WCAG 2.0: 1.4.3 Contrast (Minimum): The visual presentation of texts and images of text has a contrast ratio of at least 4.5:1 for normal text and 3:1 for large text. 14 point and bold or larger, or 18 point and larger. (Level AA)
The text was updated successfully, but these errors were encountered: