Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address insufficient contrast of white text over grey background: 0.5 #251

Closed
paregorios opened this issue Apr 24, 2018 · 9 comments
Closed
Assignees
Labels
priority: high requirement A modification levied by the University or ISAW for compliance or other mandatory reasons. WCAG AA WCAG 2.0 Conformance Level AA
Milestone

Comments

@paregorios
Copy link
Member

paregorios commented Apr 24, 2018

e.g., in breadcrumbs for people sections.

The color #FFF with background color #B5B2B0 has a contrast ratio of 2.1:1, which fails for normal sized text.

screen shot 2018-04-24 at 3 16 55 pm

Traceability: Microassist Report 1 > WCAG Compliance > Color Contrast

WCAG 2.0: 1.4.3 Contrast (Minimum): The visual presentation of texts and images of text has a contrast ratio of at least 4.5:1 for normal text and 3:1 for large text. 14 point and bold or larger, or 18 point and larger. (Level AA)

@paregorios paregorios added requirement A modification levied by the University or ISAW for compliance or other mandatory reasons. WCAG AA WCAG 2.0 Conformance Level AA labels Apr 24, 2018
@paregorios paregorios added this to the Accessibility 2018 August milestone Apr 24, 2018
@paregorios paregorios added this to To do in Accessibility 2018 via automation Apr 24, 2018
@paregorios paregorios changed the title Address insufficient contrast of white text over grey background Address insufficient contrast of white text over grey background: 0.5 May 25, 2018
@paregorios
Copy link
Member Author

In order to achieve proper contrast, make the following CSS changes:

background of gray breadcrumbs:

#portal-breadcrumbs {
    background: #ddd9d6;
    ...

links, text, and separators for the breadcrumbs:

color: #333;

Result should look like this:

screen shot 2018-12-03 at 10 52 59 am

@alecpm
Copy link

alecpm commented Dec 6, 2018

This is live on staging (whenever it's back online)

@alecpm alecpm moved this from ToDo to Reviewing in Accessibility Iteration 6 Dec 6, 2018
@alecpm
Copy link

alecpm commented Dec 6, 2018

I do think this needs a better focus indicator. Perhaps adding padding: 5px; border: 3px solid transparent; and on hover/focus border-color: blue; with a reduction in right margin from 14px to 8px to account for the additional border and padding.

@paregorios
Copy link
Member Author

Desired contrast goals achieved. I agree with @alecpm about focus/hover; I'll create a new ticket for that and let's hold this one as blocked until that other ticket has been implemented and reviewed.

@paregorios
Copy link
Member Author

@alecpm Actually, we've lost the section-specific background colors for "graduate studies," "visiting scholars," "events," and "exhibitions" (compare to production). The gray background color (which is now universal on staging) is meant only to apply to sections that are not those "colorful four".

@alecpm
Copy link

alecpm commented Dec 7, 2018

I commented out the special color sections because they seemed to have some contrast issues with the new text color. I can bring them back. I'd suggest we consider switching to white text for those (at least for the brick and "graduate studies" colors).

@paregorios
Copy link
Member Author

Yes, I'm sorry I wasn't clearer earlier. I didn't see any need to change the text color for the special-color sections; their contrast numbers were fine. This ticket should have been constrained only to breadcrumbs that were making use of the gray background.

@alecpm
Copy link

alecpm commented Dec 7, 2018

This is fixed on staging.

@alecpm alecpm moved this from Doing to Reviewing in Accessibility Iteration 6 Dec 7, 2018
@paregorios
Copy link
Member Author

Looks good. Please merge to master and deploy to production.

@paregorios paregorios moved this from Reviewing to Deploy (ISAW assigns) in Accessibility Iteration 6 Dec 7, 2018
@alecpm alecpm moved this from Deploy (ISAW assigns) to Merged to Master (Dev assigns) in Accessibility Iteration 6 Dec 7, 2018
@alecpm alecpm moved this from Merged to Master (Dev assigns) to Deployed in Accessibility Iteration 6 Dec 7, 2018
Accessibility 2018 automation moved this from To do to Done Jan 14, 2019
@paregorios paregorios moved this from Deployed to Done in Accessibility Iteration 6 Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high requirement A modification levied by the University or ISAW for compliance or other mandatory reasons. WCAG AA WCAG 2.0 Conformance Level AA
Development

No branches or pull requests

2 participants