Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix footer to correct bad page heading hierarchy: 1 #361

Closed
paregorios opened this issue Jan 14, 2019 · 2 comments
Closed

fix footer to correct bad page heading hierarchy: 1 #361

paregorios opened this issue Jan 14, 2019 · 2 comments
Assignees
@cguardia
Labels
deploy enhancement priority: high requirement A modification levied by the University or ISAW for compliance or other mandatory reasons. WCAG A WCAG 2.0 Conformance Level A
Projects
Accessibility Iteration 7
Milestone
Autumn 2018

Comments

@paregorios
Copy link
Member

paregorios commented Jan 14, 2019 •
edited

We've done a lot of work to clean up skipped heading levels and related problems in our templates, but the footer still needs some attention. Specifically, there are three bits of text that are currently wrapped in <h3> tags (the "support" link and the "gallery hours" and "library hours" headings). These three components need to be wrapped in <h2> instead. That's easy for us to do via the "ISAW Settings" control panel -> "footer HTML" editor, but some CSS modifications are required in order to preserve current look and feel.

There are currently two relevant CSS selectors:

  • .footer-row #portal-footer h3
  • .footer-row #portal-footer h3.support a

Why not duplicate each of these for h2 to read as follows and see if that takes care of the need:

  • .footer-row #portal-footer h2
  • .footer-row #portal-footer h2.support a

We don't anticipate using <h3> in the footer going forward.
@paregorios paregorios added enhancement priority: high requirement A modification levied by the University or ISAW for compliance or other mandatory reasons. WCAG A WCAG 2.0 Conformance Level A estimate needed labels Jan 14, 2019
@paregorios paregorios added this to the Autumn 2018 milestone Jan 14, 2019
@paregorios paregorios mentioned this issue Jan 14, 2019
Closed
@paregorios paregorios changed the title fix footer to correct bad page heading hierarchy fix footer to correct bad page heading hierarchy: 1 Jan 14, 2019
@cguardia cguardia self-assigned this Jan 15, 2019
@cguardia cguardia moved this from ToDo to Doing in Accessibility Iteration 7 Jan 17, 2019
@cguardia
Copy link

This is on staging.

@cguardia cguardia moved this from Doing to Reviewing in Accessibility Iteration 7 Jan 17, 2019
@paregorios
Copy link
Member Author

Looks good. Please merge to master and deploy to production.

@paregorios paregorios moved this from Reviewing to Deploy (ISAW Assigns) in Accessibility Iteration 7 Jan 17, 2019
@paregorios paregorios added deploy and removed review labels Jan 17, 2019
@cguardia cguardia moved this from Deploy (ISAW Assigns) to Merged to master (dev assigns) in Accessibility Iteration 7 Jan 18, 2019
@jessesnyder jessesnyder moved this from Merged to master (dev assigns) to Deployed in Accessibility Iteration 7 Jan 22, 2019
@paregorios paregorios moved this from Deployed to Done in Accessibility Iteration 7 May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cguardia cguardia

Labels
deploy enhancement priority: high requirement A modification levied by the University or ISAW for compliance or other mandatory reasons. WCAG A WCAG 2.0 Conformance Level A
Projects
Accessibility Iteration 7
Done
Milestone
Autumn 2018
Development

No branches or pull requests
2 participants
@paregorios @cguardia