Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Components from NuGet packages #45

Closed
3 tasks done
isc30 opened this issue May 6, 2020 · 5 comments
Closed
3 tasks done

Support Components from NuGet packages #45

isc30 opened this issue May 6, 2020 · 5 comments
Labels
feature New feature or request
Projects

Comments

@isc30
Copy link
Owner

isc30 commented May 6, 2020

Mentioned in #42

  • Check if referencing the package generates the metadata properly
  • (possibly) Check if adding the assembly to BLLManifestGeneratorAssemblyNames works
  • Document the solution
@isc30 isc30 added the feature New feature or request label May 6, 2020
@isc30
Copy link
Owner Author

isc30 commented May 6, 2020

Assemblies from PackageReferences should be added too .targets file where this happens

@isc30 isc30 added this to To do in Main Board May 6, 2020
@isc30
Copy link
Owner Author

isc30 commented May 6, 2020

Just checked a fast approach for this and im able to lazy load MatBlazor easily :)

@FrMalan
Copy link

FrMalan commented May 7, 2020

Awesome work dude! I just started playing with this for an internal project that will need to load UI modules on demand. So far for my POC phase it seems to work very good for the moment.

@isc30
Copy link
Owner Author

isc30 commented May 7, 2020

After some investigation, I'm planning to rework the manifest system a bit so I open the posibility of people implementing their own ManifestGenerators.

Loading NuGet packages works completely fine, and generating the lazy manifest for them too (by adding them to BLLManifestGeneratorAssemblyNames.

I want to implement nested Module discovery by stamping the assemblies with a custom attribute so I can join the manifests on build time on the top-most Module. This way, your project referencing the nuget package could include the BLLManifestGeneratorAssemblyNames bit itself but the parent will be aware of it too (there is no easy way of inheriting msbuild props).

Also, for modules requiring static assets (like a JS being appended to the page etc) I will need to implement #9 first.

I just created a PR (#48) with a Module that depends on Faso.Blazor.SpinKit.SpinKitWave and uses it directly and lazily.

As for the rest, #47 will do.

@isc30
Copy link
Owner Author

isc30 commented May 7, 2020

Closing the issue since it was splitted.

@isc30 isc30 closed this as completed May 7, 2020
Main Board automation moved this from To do to Done May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

No branches or pull requests

2 participants