Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in unwrap_fringe.py #52

Closed
vbrancat opened this issue Aug 11, 2021 · 0 comments · Fixed by #54
Closed

Error in unwrap_fringe.py #52

vbrancat opened this issue Aug 11, 2021 · 0 comments · Fixed by #54

Comments

@vbrancat
Copy link
Contributor

vbrancat commented Aug 11, 2021

unwrap_fringe.py fails when using SNAPHU unwrapper. The code fails because of non-existent metadata/XML file. Below an error report:

This is the Open Source version of ISCE.
Some of the workflows depend on a separate licensed package.
To obtain the licensed package, please make a request for ISCE
through the website: https://download.jpl.nasa.gov/ops/request/index.cfm.
Alternatively, if you are a member, or can become a member of WinSAR
you may be able to obtain access to a version of the licensed sofware at
https://winsar.unavco.org/software/isce
length, width:  1217   7620
Traceback (most recent call last):
  File "/home/vbrancat/Fringe/install/bin/unwrap_fringe.py", line 182, in <module>
    unwrap_snaphu(inps, length, width, metadata)
NameError: name 'metadata' is not defined

The issue popped up when I updated my main branch. At glance, the issue seems to be related to abug related to the merge of PR #45. Particularly, the bug is at line

def unwrap_snaphu(inps, length, width, metadata):
where I think metadata should be set to None by default

@hfattahi @bjmarfito

@yunjunz yunjunz linked a pull request Aug 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant