Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar not present #25

Closed
intrepidclass opened this issue Apr 20, 2016 · 8 comments
Closed

Scrollbar not present #25

intrepidclass opened this issue Apr 20, 2016 · 8 comments
Assignees

Comments

@intrepidclass
Copy link

Hi,

Thanks for this library!

On my Nexus 6 running Android 5.1.1 and my Nexus 7 (2103) running 6.01, I'm not seeing a scrollbar in my tableview.

Do I need to do something different or is this a bug?

@intrepidclass
Copy link
Author

Just checked the sample app on my Nexus 7: same thing.

@ISchwarz23 ISchwarz23 self-assigned this Apr 20, 2016
@ISchwarz23
Copy link
Owner

Hi @ciskeboekelo,
thanks for this hint. Fact is, that the TableView is currently not showing a scrollbar at all. But you are right, maybe it is helpfull to have such an indicator, especially in TableViews with a large data set. I think this will be an upcomming feature. :)
Best regards,
Ingo

@intrepidclass
Copy link
Author

Ok, so it's not me then :-)
But then how come there is a scroll bar in the animated GIF in the readme?

@ISchwarz23
Copy link
Owner

I have no idea. There has been no change corresponding to that. It's still a standard ListView. But nevertheless there should be some possibility for the TableView to adapt this.

@intrepidclass
Copy link
Author

I found the cause of this issue and have created a PR with a fix.
If you agree with the fix, could you merge it and release a new version? Thanks!

@ISchwarz23
Copy link
Owner

Thanks you very much for your effort. I will do exactly that ;)

@ISchwarz23
Copy link
Owner

Have fun with the new release compile 'de.codecrafters.tableview:tableview:2.0.1' and thank you!

@intrepidclass
Copy link
Author

Works like a charm! Thanks for the quick update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants