Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider for data and header row elements #41

Closed
Ulop opened this issue Jul 14, 2016 · 4 comments
Closed

Divider for data and header row elements #41

Ulop opened this issue Jul 14, 2016 · 4 comments
Assignees

Comments

@Ulop
Copy link

Ulop commented Jul 14, 2016

Hello! Can you add methods like this?
setDataRowElementDividerHeight()
setDataRowElementDividerColor()
setHeaderRowElementDividerHeight()
setHeaderRowElementDividerColor()

@ISchwarz23 ISchwarz23 self-assigned this Jul 14, 2016
@ISchwarz23
Copy link
Owner

Hi @Ulop,

I guess you know that there is a way to set the data row divider height and color via xml:

    <de.codecrafters.tableview.TableView
        android:id="@+id/tableView"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:divider="@color/black"
        android:dividerHeight="1dip"
        ...  /> 

So you need to set this during runtime? I also want to get sure, that we have the same understanding of the header row element divider. How does the header row element look like in your opinion?

@Ulop
Copy link
Author

Ulop commented Jul 15, 2016

Hi @ISchwarz23
Your code is way to set divider between rows in tableview. But I'm need a divider elements in row on this
rowView and on TableHeaderView(extends LinearLayout)

@ISchwarz23
Copy link
Owner

ISchwarz23 commented Jul 18, 2016

Hi Alex,
so you need some vertical lines between the cells in one row (data as well as header row)?
Best regards,
Ingo

@Ulop
Copy link
Author

Ulop commented Jul 19, 2016

Hi @ISchwarz23
Yes, that's it

@Ulop Ulop closed this as completed Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants