You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am migrating my coverage guidance update into the latest branch. Since @lazycal largely changed my graph generation implementation to support multi-input graphs, I am opening a new thread to ask a few questions about the change as a "post-review" section, though some of them might be not quite related to my merged update.
I would also recommend having a PR in the future if one made a significant change (say 500+ line new feature) to a codebase previously implemented by the other which is helpful to avoid inconsistency and bugs in our implementation. Just like what Fabian did. :-)
The text was updated successfully, but these errors were encountered:
Why do we need a random sampling here? Is it the case that we first determine the plausible data types and then assume it is the data type of selected nodes? If so, I would suggest first looking at what kind of types we have in the self.alive_shapes and then do sampling in the intersection of op.in_dtypes and types we have in the self.alive_shapes. Because according to my experience we don't have many "float64", "intxx" and "bool" types in self.alive_shape which will quickly run out of the trying budgets (max_shape_var_pick_time) we gave (i.e., 3 times).
I am migrating my coverage guidance update into the latest branch. Since @lazycal largely changed my graph generation implementation to support multi-input graphs, I am opening a new thread to ask a few questions about the change as a "post-review" section, though some of them might be not quite related to my merged update.
I would also recommend having a PR in the future if one made a significant change (say 500+ line new feature) to a codebase previously implemented by the other which is helpful to avoid inconsistency and bugs in our implementation. Just like what Fabian did. :-)
The text was updated successfully, but these errors were encountered: