Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bootstrap version to 5 #27

Closed
LordSimal opened this issue Jun 28, 2021 · 1 comment · Fixed by #29
Closed

Update bootstrap version to 5 #27

LordSimal opened this issue Jun 28, 2021 · 1 comment · Fixed by #29
Labels
enhancement New feature or request

Comments

@LordSimal
Copy link
Contributor

Since there is no special bootstrap 4 functionality present (as far as I have seen) in this plugin I would guess it wouldn't be a problem to update the default generated package.json and stubs to use bootstrap 5 instead of 4.
@ishanvyas22
Copy link
Owner

Sure, I don't think there's any harm in updating it. Will you be able to submit a PR?

@ishanvyas22 ishanvyas22 added the enhancement New feature or request label Jul 10, 2021
@ishanvyas22 ishanvyas22 linked a pull request Jul 10, 2021 that will close this issue
update generated package.json for bootstrap #29
Merged
@ishanvyas22 ishanvyas22 modified the milestone: 1.x Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update generated package.json for bootstrap LordSimal/asset-mix
2 participants
@LordSimal @ishanvyas22