Testing part1

[ishpaul777]

In this Pull request Me and my coding partner @hammaazarok Implemented the following-

• Use jest framework for testing.
• Created a test file [crud.test.js] to test the Add or Remove task to list in UI AND local Storage Functions

Updated Testing Part 2 code added see after the Approval of test part1

Following tests are written

• checks for function for editing the task description.
• checks for a function for updating an item's 'completed' status.
• checks for the "Clear all completed" function.

[OmarRamoun]

🟡 Almost There! 🏃

Hi @hammaazarok and @ishpaul777 👋

Good job so far! 👏. Your Coding Style is Impressive! 💪.

There are some few issues 🐛 that you still need to work 🔧 on though to go to the next project ⏭️ but you are almost there! 🏃

Don't Worry 🙏

It's ok to have bugs in your code 🐛. Please, see this code review as a chance for you to learn practical coding skills and learn new tips 🌟 that can improve your code quality 💯 and help you get a better job 💼.

I will guide 📔 you through fixing 🔧 these bugs 🐛, just follow my comments down below 🔽 and make sure you don't miss any of them, in order to get your project approved ✅

Highlights 🌟

• ✔️ Descriptive commmit messsages
• ✔️ Descriptive PR description
• ✔️ No linter Errors
• ✔️ Super Cool UI with Dark Mode. 👏 👍
• The code is top-notch! 💯 and have a huge potential.

Note: The UI is so cool. You have done such a great work @hammaazarok and @ishpaul777. Keep up the great work.

Required Changes ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Important Notes 📝

• Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
• Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Note: Please, don't Merge This Pull Request yet. Only Merge when it is Approved ✅.

Thank you for your time 🙏 and call me if you need help or clarification ☎️

• This is My GitHub:
• This is My Twitter:
• This is My Slack:

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[dasileker]

Hi @ishpaul777,

Congratulations! 🎉

Your project is complete! There is nothing else to say other than... it's time to merge it 🚀 :

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[ishimwezachee]

Hi @ishpaul777 ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Linters are passing 👍
Project is running successfully 👍

Required Changes ♻️

I have tried to run your test, but seemed like jest is somehow configured in wrong way, please fix so that I can run the test successfly

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[ishpaul777]

@ishimwezachee Thanks for taking time to review the Pull Request. there are certain dependencies which you have to install to make the tests work you have install Babel, jest, and jsdom in local environment to make the tests work.
Run npm install to download all dependences

[Nemwel-Boniface]

Hello @ishpaul777 👋 ,

I am Nemwel your reviewer for this PR 🧔‍♂️

Thank you for meeting all the project requirements all your tests pass! good job! 🥳
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🥳 🎉

Highlights

Great job setting up the correct linters ✔️
Professional documentation ✔️
Correct workflow ✔️
Meaningful commit messages ✔️
Met all the milestone requirements ✔️

[Optional] suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.