Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize node dispatching #2

Closed
isidentical opened this issue Jul 23, 2021 · 1 comment
Closed

Optimize node dispatching #2

isidentical opened this issue Jul 23, 2021 · 1 comment

Comments

@isidentical
Copy link
Owner

We could try to reduce the number of .match() calls we are making by giving Rules to register certain types of nodes. This will eliminate the top level assert isinstance(node, <node type>) check from their side and made our refactor loop faster.
@isidentical
Copy link
Owner Author

Now thinking about it, it doesn't seem to yield much in terms of performance since isinstance check is done no matter what :/ I'll re-open this if I can find a better way to solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isidentical