New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colored point cloud registration & Multi-scale approach #64
Comments
Let me answer the easier question first: The multi-scale thing can be in the python script. We can have an additional layer in C++. E.g., a function called ICPRegistrationMultiScale, but we do not encourage user to use it. The reason is that the parameters might need to be tune. So in this case, we leave the multi-scale function in python is a good choice. |
Now the harder question: Define a class called
|
Yeah, this looks great! And I think it is just plug and play! |
wait, there is one problem, that we cannot make estimate
Let me think. |
The easiest way is to follow my suggestions, with these additional changes:
I think it is viable and legitimate. After all, the purpose of using a class for TransformationEstimation is to store some intermediate results that can be useful (e.g., the color gradient). What do you think? |
Yes. I agree that this is appropriate way to extend |
Let's make it clear, So we want to change
as to be
right? I had removed |
Yes, I think so. |
I just noticed that OS X prohibit referencing of non-constant type.
This will makes following error:
If I remove
This error is not showed up in Visual Studio. Am I doing some stupid mistake? |
Yes, you cannot use reference. Because the default initializer produce a const You cannot remove I think the easiest fix is to remove the default initializer. So try this:
The downside though, is that it is really ugly. And we cannot use function calls like:
Do you have any better ideas? |
Well I guess we don't have enough choice. I don't have better idea for now. |
Let me think. I actually think we can restructure the entire thing. But let me think a bit. |
Based on the discussion today, I understood that following code structure in PointCloudForColoredICP.h
in TransformationEstimation.h
in TransformationEstimation.cpp
Any mistakes I made? |
Regarding the line People regard it as not good idea because the variables in derived class would be not initialized. Check out this link |
Everything should be in two files:
First, put proper citation to our paper in the header file, right before the entrance function. Here is the
|
Seems good, but I am not clear following line.
RegistrationICP only can take |
I am trying to implant our ICCV code to Open3D.
The files I am editing are core/registration/TransformationEstimation.h/cpp and Registration.cpp. The question is the following virtual function:
for colored points registration, we need additional argument e.g. point-wise color gradient for computing Jacobian. Any good idea for this?
In addition, we know the multi-scale registration really helps registration fidelity. Our ICCV implementation code is based on this idea, but I would like to make a new wrapper class so all the ICP methods in Open3D can get benefits. How do you think?
The text was updated successfully, but these errors were encountered: