Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Button to switch camera #15

Closed
Tmin10 opened this issue Sep 2, 2020 · 5 comments · Fixed by #115
Closed

[Feature] Button to switch camera #15

Tmin10 opened this issue Sep 2, 2020 · 5 comments · Fixed by #115
Assignees
Labels
android-app feature New feature or request
Projects

Comments

@Tmin10
Copy link

Tmin10 commented Sep 2, 2020

Hello. I run the app on my phone but it display picture from front camera. After debugging I realize that I need to change https://github.com/intel-isl/OpenBot/blob/master/android/app/src/main/java/org/openbot/CameraActivity.java#L110 to 0 (LENS_FACING_FRONT) and it working fine... I don't know why front and back are reversed in my case but it could help you in future for debug the same problems.

My device is Asus Zenfone Max Pro (M2) ZB631KL, Android 9. Other cameras apps working fine.

@thias15
Copy link
Collaborator

thias15 commented Sep 2, 2020

We have not encountered this on any phone before. Thanks for opening this issue, we will keep an eye on it. I will close it for now, since I don't expect this to be a general issue.

@thias15 thias15 closed this as completed Sep 2, 2020
@Tmin10
Copy link
Author

Tmin10 commented Sep 2, 2020

Yep, thanks. Maybe in future it is possible to add camera switch into the settings.

@thias15 thias15 reopened this Sep 29, 2020
@thias15 thias15 changed the title Wrong camera in the app [Feature] Button to switch camera Sep 29, 2020
@thias15 thias15 self-assigned this Sep 29, 2020
@thias15 thias15 added this to To do in OpenBot Sep 29, 2020
@thias15 thias15 added feature New feature or request android-app labels Sep 30, 2020
@eagleanurag
Copy link
Contributor

eagleanurag commented Oct 11, 2020

Hello. I run the app on my phone but it display picture from front camera. After debugging I realize that I need to change https://github.com/intel-isl/OpenBot/blob/master/android/app/src/main/java/org/openbot/CameraActivity.java#L110 to 0 (LENS_FACING_FRONT) and it working fine... I don't know why front and back are reversed in my case but it could help you in future for debug the same problems.

My device is Asus Zenfone Max Pro (M2) ZB631KL, Android 9. Other cameras apps working fine.

in my case also when i used my old Samsung J7 Max by default front camera opens

@vkuehn
Copy link
Contributor

vkuehn commented Nov 17, 2020

Hi I have a solution for that, can you kindly assign it to me ?
Sorry it will be not fully compliant with your naming rules..this time

@thias15 thias15 linked a pull request Nov 17, 2020 that will close this issue
OpenBot automation moved this from To do to Done Nov 19, 2020
@thias15 thias15 moved this from Done to To do in OpenBot Dec 7, 2020
@vkuehn
Copy link
Contributor

vkuehn commented Dec 8, 2020

is there an issue why it is a ToDo again ?

@thias15 thias15 moved this from To do to Done in OpenBot Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app feature New feature or request
Projects
OpenBot
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants