Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up work of #41 #51

Closed
syncle opened this issue Jun 22, 2017 · 4 comments
Closed

Follow up work of #41 #51

syncle opened this issue Jun 22, 2017 · 4 comments
Assignees

Comments

@syncle
Copy link
Contributor

syncle commented Jun 22, 2017

#41 covers basic data structure and functions for RGBD odometry application.
There are few issues additionally need to be handled.

  • OpenMP boosted version is not that fast enough: I expect 4~5 times faster when OpenMP is used, but the performance gain is not obvious. Should be handled.
  • Some example that shows Hybrid odometry is better than old odometry.
@qianyizh
Copy link
Collaborator

We should also show case a complete tutorial starting from downloading one of the TUM sequences, then ran odometry, then evaluating. In general, what we did in our paper.

@syncle
Copy link
Contributor Author

syncle commented Jun 23, 2017

We have better OpenMP support from the discussion of #52, but when the enhanced OpenMP code applied to RGBDOdometryJacobian, the performance gain is still not as drastic as #52. I think maybe due to extensive random correspondence search and memory reference.
One way to boost is reducing the number of correspondences: not searching correspondences for every pixels, maybe for every two pixels. This will boost 4x at least.

@syncle
Copy link
Contributor Author

syncle commented Jun 28, 2017

We have better OpenMP support from the discussion of #52, but when the enhanced OpenMP code applied to RGBDOdometryJacobian, the performance gain is still not as drastic as #52. I think maybe due to extensive random correspondence search and memory reference.

Fixed. See #52 and #53.

One way to boost is reducing the number of correspondences: not searching correspondences for every pixels, maybe for every two pixels. This will boost 4x at least.

Offline discussed, but making tutorial has higher priority for now.

@qianyizh
Copy link
Collaborator

qianyizh commented Dec 4, 2017

Done. Close.

@qianyizh qianyizh closed this as completed Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants