Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade doiuse #149

Closed
tranvansang opened this issue May 21, 2021 · 7 comments · Fixed by #150
Closed

Upgrade doiuse #149

tranvansang opened this issue May 21, 2021 · 7 comments · Fixed by #150
Labels

Comments

@tranvansang
Copy link

tranvansang commented May 21, 2021

Related issue: postcss/postcss#1561

Hello,

Thank you very much for the great package.

Currently, I am facing this error when running stylelint with stylelint-no-unsupported-browser-features enabled.

(node:1333057) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at <rootdir>/node_modules/doiuse/node_modules/postcss/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use `node --trace-deprecation ...` to show where the warning was created)

The culprit is only because of the old doiuse version included in stylelint-no-unsupported-browser-features. This old doiuse import old postcss version which causes the deprecation warning.

Could you please upgrade the doiuse version so I can continue using this stylelint-no-unsupported-browser-features plugin?

@ismay
Copy link
Collaborator

ismay commented May 21, 2021

Hi @tranvansang,

@ismay ismay closed this as completed May 21, 2021
@ismay
Copy link
Collaborator

ismay commented May 21, 2021

I've closed the issue since it doesn't seem like there's an issue with the version of doiuse we've specified in package.json. However, please let me know if there has been an oversight or if there's anything else that seems off! Hope that helps 😊!

@tranvansang
Copy link
Author

hmm,

It looks like the latest doiuse version is 4.4.1.

https://www.npmjs.com/package/doiuse/v/4.4.1

@ismay
Copy link
Collaborator

ismay commented May 21, 2021

hmm,

It looks like the latest doiuse version is 4.4.1.

https://www.npmjs.com/package/doiuse/v/4.4.1

Ah I guess their GH releases page hasn't been updated alongside their npm publishes, that lists 4.3.1: https://github.com/anandthakker/doiuse/releases. Still, the range we specify is "^4.3.1", so doiuse 4.4.1 will still be installed if your other dependencies allow it. See here https://semver.npmjs.com:

Screenshot 2021-05-21 at 21 10 38

@tranvansang
Copy link
Author

I've successfully bumped doiuse to the latest version. Now, the deprecation warning is gone.

yarn remove stylelint-no-unsupported-browser-features
yarn add doiuse
yarn add -D stylelint-no-unsupported-browser-features
yarn remove doiuse
git add yarn.lock

Thanks very much for your time, and have a nice weekend.

ismay pushed a commit that referenced this issue May 22, 2021
ismay pushed a commit that referenced this issue May 22, 2021
ismay pushed a commit that referenced this issue May 22, 2021
ismay pushed a commit that referenced this issue May 22, 2021
ismay pushed a commit that referenced this issue May 22, 2021
ismay pushed a commit that referenced this issue May 22, 2021
# [5.0.0](v4.1.4...v5.0.0) (2021-05-22)

### Bug Fixes

* **dependencies:** fix doiuse warning ([c79336f](c79336f)), closes [#149](#149)

### Code Refactoring

* **support:** drop support for node 10 ([72e07bc](72e07bc))
* **support:** drop support for stylelint v11 and v12 ([4d5a108](4d5a108))

### BREAKING CHANGES

* **support:** support for node 10 dropped
* **support:** support for stylelint v11, v12 dropped
@ismay
Copy link
Collaborator

ismay commented May 22, 2021

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ismay ismay added the released label May 22, 2021
@ismay
Copy link
Collaborator

ismay commented May 22, 2021

Thanks for the help @tranvansang! Since the latest version of doiuse fixed the issue I've bumped the doiuse version for this plugin to 4.4.1. That should resolve it for everyone. I've also done some other housekeeping, has been releases as v5. Let me know if anything comes up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants