Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 3 template preventing knitting #122

Closed
kelseygonzalez opened this issue Jan 28, 2021 · 8 comments
Closed

Chapter 3 template preventing knitting #122

kelseygonzalez opened this issue Jan 28, 2021 · 8 comments
Assignees

Comments

@kelseygonzalez
Copy link

Describe the bug
When rendering the default template, there's something in chapter 3 that Latex is now struggling to render that is breaking the build.

To Reproduce
Create a new thesisdown from the template, and click knit from the index.Rmd file. Error from the console / thesis.log:

Chapter 3.
! Missing number, treated as zero.
<to be read again> 
                   (
l.553 ...columnwidth - 2\tabcolsep) * \real{0.31}}
                                                  \centering 

Expected behavior
I expect it to render the default document.

Desktop (please complete the following information):

  • OS: Windows
  • Version R version 4.0.3 (2020-10-10) -- "Bunny-Wunnies Freak Out"

Additional context
This could definitely be a latex issue on my own computer. I've been fighting with it all day but this error has persisted. If I delete most of the chapter 3, the error disappears and the document renders.

@ismayc
Copy link
Owner

ismayc commented Jan 28, 2021

Hi there. I think this might be the table that I have added in to demo that in Chapter 3 as that has caused issues with LaTeX before. It's probably best to just remove that Markdown table and generate tables with R instead.

@kelseygonzalez
Copy link
Author

Indeed @ismayc - I just tested by removing only the markdown table at the beginning and it rendered. Sounds like it's time to rid ourselves of that pesky table!

@ismayc
Copy link
Owner

ismayc commented Jan 28, 2021

I'll look into updating the template over the next few days so others don't have this same issue when they do a fresh build. Thanks for reporting!

@Xyv
Copy link

Xyv commented Feb 2, 2021

Hey,
Pandoc has recently changed the way they compute the the column widths in tables: jgm/pandoc@bd7c9eb
Adding \usepackage{calc} in the template fixes this.
And thanks for all the work you've done!

EDIT: They've made a few more changes regarding tables since were you might require to include array too. (jgm/pandoc@7c4d7db)
For reference, I made my own template and stumbled onto the same problem, I've skimmed through the last few commits on the default.latex template to catch the culprits.

@ismayc
Copy link
Owner

ismayc commented Feb 2, 2021

Thank you! That's super helpful

@Xyv
Copy link

Xyv commented Feb 3, 2021

My pleasure, happy to be of some help to this nice project.

@ismayc
Copy link
Owner

ismayc commented Feb 7, 2021

Pushed to master in #124

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org whenever possible) and link to this issue. If a reprex is not applicable, recording a short Loom video showing what you are seeing can go a long way in helping to diagnose problems.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants