Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test to verify the YAML file #1

Closed
2 tasks
ejhumphrey opened this issue Oct 12, 2018 · 4 comments
Closed
2 tasks

add test to verify the YAML file #1

ejhumphrey opened this issue Oct 12, 2018 · 4 comments

Comments

@ejhumphrey
Copy link
Collaborator

ejhumphrey commented Oct 12, 2018

tests should verify that

  • the yaml can be read
  • all URLs don't return a 400+?

maybe other things?

@faroit
Copy link
Contributor

faroit commented Mar 8, 2019

I will try to find some time for this. I would do it in py.test, ok?

@ejhumphrey
Copy link
Collaborator Author

❤️ pytest! We've already got the requirements file, so a test_database.py or equivalent will be 👌

I'm realizing that there are actually two things to be done here – add the test file to verify the yaml is valid, and then (later) actually setting this up in a CI/CD framework, e.g. Travis, circle-ci, etc. I'll update this issue to be only the former, and create a new issue for the CI/CD thing specifically, which is a heavier (and subsequent) lift.

@ejhumphrey ejhumphrey changed the title add CI/CD to verify the YAML file add test to verify the YAML file Mar 8, 2019
@faroit
Copy link
Contributor

faroit commented Mar 13, 2019

Started in #8, it also integrates CI, hence #7.

all URLs don't return a 400+?

I check for 200, is this too strict?

@faroit faroit mentioned this issue Jun 4, 2019
@stefan-balke
Copy link
Contributor

Integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants