Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming finally to make_final_act #141

Closed
trebconnell opened this issue Sep 25, 2015 · 1 comment
Closed

Renaming finally to make_final_act #141

trebconnell opened this issue Sep 25, 2015 · 1 comment
Labels

Comments

@trebconnell
Copy link
Contributor

make_final_act (or make_final) would be more consistent with other std construction helpers such as make_unique.

Additionally there's danger of finally accidentally being called without assigning into a temporary, thus inducing the destructor to activate immediately. The static analysis could catch this, or renaming makes this sort of mistake less likely to happen imo.

@AndrewPardoe
Copy link
Contributor

We prefer the status quo: we'll keep this as finally. See TC++PL 4 on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants