Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Type.2: Don't use static_cast downcasts. Use dynamic_cast instead." only works for polymorphic objects #270

Closed
mgehre opened this issue Oct 2, 2015 · 2 comments
Closed

"Type.2: Don't use static_cast downcasts. Use dynamic_cast instead." only works for polymorphic objects #270

mgehre opened this issue Oct 2, 2015 · 2 comments
Assignees
@BjarneStroustrup
Labels
resolved review

Comments

@mgehre
Copy link

mgehre commented Oct 2, 2015

If the object is not polymorphic, then dynamic_cast cannot replace static_cast. This should be explicitly mentioned in the rule.
@gdr-at-ms gdr-at-ms added the open label Oct 5, 2015
@hsutter hsutter added review and removed open labels Oct 5, 2015
@hsutter
Copy link
Contributor

hsutter commented Oct 5, 2015

Bjarne will add wording to cover this. Part of the answer is that if it's not polymorphic you shouldn't be using static_cast either.

@BjarneStroustrup
Copy link
Contributor

added an example and explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BjarneStroustrup BjarneStroustrup

Labels
resolved review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mgehre @hsutter @BjarneStroustrup @gdr-at-ms and others