Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with README.md statement #9

Closed
mykeels opened this issue Jan 14, 2017 · 6 comments
Closed

Issue with README.md statement #9

mykeels opened this issue Jan 14, 2017 · 6 comments

Comments

@mykeels
Copy link

mykeels commented Jan 14, 2017

Awesome repo!

However, this statement about the close-knit-nature of Routes to Controllers appears to be false: "It's a new way of thinking about the way applications should be crafted!"

I suggest it's looked into.

@isocroft
Copy link
Owner

Good observation @mykeels

How do you mean ? Can you elucidate further ?

@shalvah
Copy link

shalvah commented Jan 23, 2017

I think he means that the statement isn't correct, because traditionally MVC routes made use of the controller/action paradigm, so saying this is new is misleading. See also https://www.codeproject.com/tips/573454/routing-in-mvc

@mykeels
Copy link
Author

mykeels commented Jan 23, 2017

Yea @shalvah. I'm sorry, @isocroft ... I couldn't reply earlier.

I know for a fact that ASP.NET MVC makes use of the ~/controller/action/{id} route by default, which makes that assertion wrong.

I think it should be modified ...

@isocroft
Copy link
Owner

isocroft commented Jan 23, 2017

i read this: https://www.codeproject.com/tips/573454/routing-in-mvc

I will effect the change in the README.md file soonest. Funny, I'm not an ASP.NET Dev. So i didn't think it had it already.

Thank a lot @mykeels and @shalvah for bringing this to my attention to this.

@isocroft
Copy link
Owner

@mykeels and @shalvah check out the changes to the README.md file. Just to make sure everything is alright.

@isocroft
Copy link
Owner

Okay, i think it's safe to say i have dealt well enough with this one. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants