Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insecure #2

Closed
alfondotnet opened this issue Apr 21, 2017 · 0 comments
Closed

insecure #2

alfondotnet opened this issue Apr 21, 2017 · 0 comments

Comments

@alfondotnet
Copy link

Hi!, thanks for the talk today at memSQL, I found it extremely valuable as I haven't found time yet to explore the concept of SSR.

However, I noticed that you use stringify without escaping HTML entities, this could create an scenario of a persisted XSS vulnerability that wouldn't get caught by XSSAuditor or the like. For example:

screen shot 2017-04-20 at 9 28 47 pm

alfondotnet@e8181f6

So you would want to use a safe version of stringify that would escape html entities to avoid this problem.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant