-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: git log the history of one file only #1172
Conversation
with follow supports now, you should set |
The another same pr is snowyu:feat/log-async-iterator, It make code more clear to read for using the async iterator. But I have to add the |
Regarding: This is tricky to do well without having implemented git's actual algorithm for detecting file renames. Comparing just the file It ends up doing more CPU/IO work to exhaustively determine the file moved rather than was copied, but |
Aha, I missed a plurality of the same content exists, thank you pointed out. The |
Ok, I've resolved though comparing all the filepaths with last all filepaths of the same content to determine the correct file name. |
Hi, I'm a new maintainer and I will be able to merge your PR if you resolve the conflicts in the files. |
Merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the conflict, there was a change:
if (tips.length === 0) {
break
}
was removed.
Also please remove the example git hooks from testing fixtures.
It has changed to this: // Stop the loop if there are no more commit parents
if (tips.length === 0) {
endCommit(commit)
break
} |
You added a line to the code that got removed. There are no longer that // Stop the loop if there are no more commit parents
if (tips.length === 0) {
endCommit(commit) // this make the conflict because surrounding code got removed
break
} |
So please update your fork with the latest version. And check how you can do the same without that line. Right now the code don't use |
Oh, I didn't notice that the mian branch has been updated again. done.. |
Note that |
You've merged |
Sorry I was mistaken your fork was updated. I need to look closer at your code since the logic of that loop was modified recently. |
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: log a single file history of commits * feat: log a single file history of commits with follow supports. resolved isomorphic-git#933 * chore(test): jasmine do not support the rejects.toThrowError * docs: add @snowyu as a contributor * fix: log file should not add commit when since time * chore(test): update fixture to check multi deletions log * chore(test): refresh test snapshot for multi deletions log * fix(rename): do not search the empty content as filepath in tree * fix: can not show all history of multi deletions log * feat: return all the filepaths of the same content in the tree * fix: git --follow should work with multi same content file * test: add test git follow with multi same content files * test(log-file): remove unused example git hooks * chore(log-file): fix declaraton document for force and follow options * chore(log-file): correct the declarayion doc * chore(log-file): correct the declarayion doc in commands
Currently the
git.log
shows all history of the commits. Miss the commits history of the filepath only.