Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cache object #1289

Merged
merged 4 commits into from Dec 17, 2020
Merged

Add missing cache object #1289

merged 4 commits into from Dec 17, 2020

Conversation

alex-titarenko
Copy link
Contributor

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Add missing cache object]"

@billiegoose
Copy link
Member

Good catch! Thanks. It would be nice to finish typing all the internals so that TypeScript could catch these errors automatically....

I have no idea why the automated tests are struggling. It's not due to your change though. Hopefully it won't block publishing once I merge it or I'll have to spend the weekend fighting with Sauce Labs and Azure DevOps again :/

@billiegoose billiegoose merged commit baf668b into isomorphic-git:main Dec 17, 2020
@alex-titarenko alex-titarenko deleted the patch-1 branch December 17, 2020 04:24
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants