Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type of WalkerMap #1314

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Conversation

mkizka
Copy link
Contributor

@mkizka mkizka commented Feb 13, 2021

fix #1313

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

@jcubic
Copy link
Contributor

jcubic commented Jun 28, 2021

Hey, can you resolve the conflicts? I'm a new maintainer and will merge the PR if there are no merge issues.

@mkizka
Copy link
Contributor Author

mkizka commented Jun 28, 2021

Thanks for your comment. There was a mistake in the commit user, so I am fixing it with force-push. Please wait a little more. Conflict is resolved? Thank you!

@mkizka
Copy link
Contributor Author

mkizka commented Jun 28, 2021

My problem was resolved. It's okay to merge this PR.

@jcubic jcubic merged commit c6b924c into isomorphic-git:main Jun 28, 2021
@jcubic
Copy link
Contributor

jcubic commented Jun 28, 2021

Hi, the conflict was not resolved, I've needed to resolve it myself. Thanks for the PR.

@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
* fix: fix type of WalkerMap

* docs: add @mkizka as a contributor

Co-authored-by: Jakub T. Jankiewicz <jcubic@onet.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the type of WalkerMap wrong?
3 participants