fix: cleanup on clone error #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion" errors in React Native (isomorphic-git#1156)
|
🎉 This PR is included in version 1.8.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
modesty
pushed a commit
to modesty/isomorphic-git
that referenced
this pull request
Apr 9, 2024
* chore: fix broken link in README.md (isomorphic-git#1154) * fix(react-native): fix for "<Intermediate Value>.stream is not a function" errors in React Native (isomorphic-git#1156) * Added an error handler for cleanup after failed clone * chore: add comments * fix: add recursive delete helper & tests Co-authored-by: Xavier Francisco <xavier.n.francisco@gmail.com> Co-authored-by: Corbin Crutchley <crutchcorn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1283.
When
clonefails, thegitdiris removed. Thediris left alone, since it might exist beforecloneis invoked.I've also added a test case for this behavior.
As mentioned in the issue, I had to write a helper to recursively delete using the custom
FileSysteminterface used in this project.