Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveBranch #39

Closed
billiegoose opened this issue Dec 28, 2017 · 6 comments · Fixed by #1175
Closed

moveBranch #39

billiegoose opened this issue Dec 28, 2017 · 6 comments · Fixed by #1175

Comments

@billiegoose
Copy link
Member

No description provided.

@billiegoose billiegoose added this to the v1.0.0 milestone Dec 28, 2017
@billiegoose billiegoose added this to v1.0.0 in Planning Dec 28, 2017
@billiegoose billiegoose moved this from v1.0.0 to v1.1.0 in Planning Dec 28, 2017
@erdahuja
Copy link
Contributor

can you help me implement any one of the features? like reset, move etc It's my first commit.

@billiegoose
Copy link
Member Author

I'm visiting my parents this weekend (it's Father's Day in the USA) so I can't directly help today, but if you give it a shot and get stuck you can ask questions!

@mojavelinux
Copy link
Contributor

I case could be made either way, but I think renameBranch would be a more fitting name. (Both terms are used in the git documentation, but what's really happening is that the branch is getting a new name. Plus, the name of the operation in Node's fs module to rename/move a file is "rename". So the terminology might be expected.)

@crutchcorn
Copy link
Contributor

I think renameBranch would be ideal as well. I'd like to take on development for this issue, but don't know where to start in terms of reference for how to actually implement this logic. I'll take a look through the createBranch logic, but will ping here if/when stuck

@crutchcorn
Copy link
Contributor

I decided I would do an experiment and simply clone two of the exact same repo, then locally rename the master branch to main in one of them, then use SmartSyncronize to compare and contrast the difference between the two.

It seems like the following actions need to be done:

  1. Change the config branch name
  2. Change the head ref
  3. Move the ref/heads old branch name file to a file with the new branch name

I'll read through the codebase to see what code is already present and what code needs to be written

@isomorphic-git-bot
Copy link
Member

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants