Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove stray {...object} #569

Merged
merged 2 commits into from Nov 7, 2018
Merged

fix: remove stray {...object} #569

merged 2 commits into from Nov 7, 2018

Conversation

billiegoose
Copy link
Member

For some reason, Object spread properties are still causing trouble, particularly with https://bundlephobia.com/. Therefore, I'm changing the one object spread property to an Object.assign.

@isomorphic-git-bot
Copy link

Thank you wmhilton! I noticed some potential linting errors, so I auto-formatted the code using prettier-standard. I hope you don't mind. 🤖

@karma-pr-reporter
Copy link

Test Results for 45e2940:

Browser Passed Skipped Failed Time Disconnected Error
HeadlessChrome 0.0.0 (Linux 0.0.0) 220 1 0 57.837 secs false undefined
Firefox 62.0.0 (Ubuntu 0.0.0) 220 1 0 1 min 29.626 secs false undefined
Safari 12.0.0 (Mac OS X 10.13.6) 220 1 0 2 mins 26.333 secs false undefined
Chrome Mobile 67.0.3396 (Android 7.1.1) 220 1 0 4 mins 55.501 secs false undefined
Edge 17.17134.0 (Windows 10 0.0.0) 220 1 0 5 mins 29.618 secs false undefined
Mobile Safari 11.0.0 (iOS 11.2.0) 220 1 0 6 mins 50.875 secs false undefined

@karma-pr-reporter
Copy link

Test Results for 22fd6bb:

Browser Passed Skipped Failed Time Disconnected Error
HeadlessChrome 0.0.0 (Linux 0.0.0) 220 1 0 55.033 secs false undefined
Firefox 62.0.0 (Ubuntu 0.0.0) 220 1 0 1 min 31.776 secs false undefined
Mobile Safari 11.0.0 (iOS 11.2.0) 220 1 0 5 mins 7.113 secs false undefined
Edge 17.17134.0 (Windows 10 0.0.0) 220 1 0 5 mins 20.013 secs false undefined
Safari 12.0.0 (Mac OS X 10.13.6) 220 1 0 5 mins 41.952 secs false undefined
Chrome Mobile 67.0.3396 (Android 7.1.1) 220 1 0 6 mins 25.384 secs false undefined

@billiegoose billiegoose merged commit e97a45d into master Nov 7, 2018
@billiegoose billiegoose deleted the oh-webpack branch November 7, 2018 05:45
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 0.39.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

billiegoose added a commit that referenced this pull request Nov 7, 2018
modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants