Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe area not respected on iPad Pro with floating keyboard #311

Closed
Snowy1803 opened this issue May 29, 2021 · 4 comments
Closed

Safe area not respected on iPad Pro with floating keyboard #311

Snowy1803 opened this issue May 29, 2021 · 4 comments
Assignees
Labels
🐛 bug Something isn't working
Projects
Milestone

Comments

@Snowy1803
Copy link

Describe the bug
The bottom of the terminal, where I'm writing the commands, is invisible as it's obscured by the keyboard accessory toolbar, which is itself not respecting the bottom safe area inset

Informations

  • Device : iPad Pro 12.9 5th Gen (2021)
  • OS : iOS 14.6
  • WebSSH Pro version : 14.17.10

Screenshots
image

To Reproduce
Steps to reproduce the behavior:

  1. Open an ssh session
  2. Cat a big file so the terminal takes up all the vertical space
  3. Pinch the keyboard to get the floating keyboard
  4. Can't see what you write anymore
@isontheline
Copy link
Owner

Bonjour @Snowy1803 Emil 🇫🇷 👋

Thank you a lot for your bug report!
You're right Safe Area Inset is not respected when the keyboard is detached and I will make a fix as soon as I can.

Belle journée à vous ☀️

@isontheline isontheline self-assigned this May 30, 2021
@isontheline isontheline added the 🐛 bug Something isn't working label May 30, 2021
@isontheline isontheline added this to the 14.18 - Mushroom milestone May 30, 2021
@isontheline isontheline modified the milestones: 15.0, 16.0 Jul 4, 2021
@Snowy1803
Copy link
Author

:/

@isontheline isontheline modified the milestones: 16.0, 15.1 - Panda Aug 15, 2021
@isontheline isontheline added the 🚧 wip Work In Progress label Aug 15, 2021
@isontheline
Copy link
Owner

isontheline commented Aug 15, 2021

WIP

image

WebSSH 15.1.1 will be available on TestFlight in a few hours.
I will ping when available.

@isontheline isontheline added testflight-release-needed and removed 🚧 wip Work In Progress labels Aug 15, 2021
@isontheline
Copy link
Owner

@Snowy1803 Now fixed inside WebSSH 15.1.1 : https://testflight.apple.com/join/QSrBK59z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
SSH
Awaiting triage
Development

No branches or pull requests

2 participants