Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape mode with iPhone notch #332

Closed
zephyr2k7 opened this issue Jun 27, 2021 · 14 comments
Closed

Landscape mode with iPhone notch #332

zephyr2k7 opened this issue Jun 27, 2021 · 14 comments
Assignees
Labels
🐛 bug Something isn't working
Projects

Comments

@zephyr2k7
Copy link

zephyr2k7 commented Jun 27, 2021

Describe the bug
Part of the terminal is hidden when using the iPhone in landscape mode

Informations

  • Device : iPhone 11 Pro
  • OS : ios14
  • WebSSH Pro version : latest from app store

Screenshots

To Reproduce
Steps to reproduce the behavior:

  1. open a ssh shell
  2. go in landscape
  3. press enter at some point the text is hidden by the notch
@isontheline isontheline self-assigned this Jun 27, 2021
@isontheline isontheline added the 🐛 bug Something isn't working label Jun 27, 2021
@isontheline isontheline added this to the 15.0 milestone Jun 27, 2021
@isontheline isontheline changed the title portrait mode on iphone notch Landscape mode with iPhone notch Jun 27, 2021
@isontheline
Copy link
Owner

Hello @zephyr2k7 👋

Thank you for your bug report about the notch on iPhone!

I will make a fix in order to prevent text hiding by the notch.

@isontheline isontheline modified the milestones: 15.0, 16.0 Jul 4, 2021
@akuropka
Copy link

akuropka commented Jul 16, 2021

Actually my experience is if started in landscape mode it works´.
However, once coming from portrait to landscape the terminal includes the notch part and makes things partly invisible.
Going back to landscape brings some funny display in the right corner as well...
PNG image
(Anyways, I usually don't use landscape mode.)

@isontheline
Copy link
Owner

Thanks for your feedback @akuropka 👍

I'm keeping this issue for a future release because 2FA and macOS x86 have a higher priority

@isontheline isontheline removed this from the 16.0 milestone Aug 19, 2021
@isontheline
Copy link
Owner

Need to improve landscape mode

Please add a margin to landscape mode on iPhone. The notch and round border cut off a lot of displayed info. It’s quite annoying.

By Gink X on the App Store

@isontheline
Copy link
Owner

From #729 (comment)

@isontheline
Copy link
Owner

isontheline commented Sep 25, 2022

Are you always experiencing problems with 20.0 under iOS 16?

@isontheline isontheline added this to the 20 - Moon milestone Sep 25, 2022
@zephyr2k7
Copy link
Author

zephyr2k7 commented Sep 26, 2022 via email

@isontheline
Copy link
Owner

Thank you a lot for your feedback @zephyr2k7 🙏

@Suspectxyzz
Copy link

for me the problem still persisted
I have the latest app update 20.1
iOS : 15.6.1 iPhone X
4980537D-DA2A-4C26-A24F-1797206A9637

@isontheline
Copy link
Owner

@Suspectxyzz Could you make a photo of the issue an the reproduce steps?
On my Xr the problem has gone.

@Suspectxyzz
Copy link

@Suspectxyzz Could you make a photo of the issue an the reproduce steps?
On my Xr the problem has gone.

sorry for the late reply but i was busy and forgot

I have the latest app update 20.1
iOS : 15.6.1 iPhone X

https://streamable.com/vrieku

@isontheline
Copy link
Owner

Thanks for your feedback @Suspectxyzz

I'm reopening this issue

@isontheline isontheline reopened this Oct 1, 2022
@Suspectxyzz
Copy link

Hello, with today's update you solved this bug, but others appeared 🫡
It doesn't work to delete folders, I think you know it's old in "STFP" (https://streamable.com/dyvc9r)
&
And with new edit text you can't select more or press the x button to delete faster
(https://streamable.com/of5lvk) ‘I noticed that you can't open files of any kind with this new text to edit even 1mb in size’

Last update (app Store )

@isontheline
Copy link
Owner

Hello @Suspectxyzz 👋

Thank you a lot for all your feedback 👍

Could you open an issue for each trouble?
Without distinct issues I can't plan the fixes easily.

@isontheline isontheline modified the milestones: 20 - Moon, 21 - Penguin Dec 11, 2022
@isontheline isontheline removed this from the 22 - Butterfly milestone May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
SSH
Awaiting triage
Development

No branches or pull requests

4 participants