Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy & Paste improvements #722

Closed
jarrah31 opened this issue Aug 28, 2022 · 6 comments
Closed

Copy & Paste improvements #722

jarrah31 opened this issue Aug 28, 2022 · 6 comments
Assignees
Labels
✨ enhancement New feature or request

Comments

@jarrah31
Copy link

Hi Arnaud, thank you for letting us test a new way of copy/pasting text within WebSSH.

As the other threads are now closed I thought I'd open a new one for us to provide feedback on this feature.

iOS

  • If the keyboard is hidden and you hold-touch the screen, the menu hides behind the keyboard and the console drops down and leaves a white section at the top. It doesn't always do this but I can't work out the exact steps to reproduce.
  • Touch mode -> Select text. Selecting text less then around 8 characters makes the keyboard appear / disappear. It's also really difficult to select text on iOS (not tested iPadOS), and could do with the OS' built-in method of text highlighting
  • How do we copy text once highlighted? Tapping it just brings up the keyboard and highlight is lost. Touch holding brings up the menu, but selecting Copy -> Copy Selected doesn't make sense. What should happen here? Does it then copy any text I highlight?

There's more but I've run out of time this evening. Will do more testing tomorrow. 👍

@isontheline
Copy link
Owner

Hi @jarrah31 👋

Thank you to open a new issue to track feedback improvements about copy / paste feature 👍

If the keyboard is hidden and you hold-touch the screen, the menu hides behind the keyboard and the console drops down and leaves a white section at the top. It doesn't always do this but I can't work out the exact steps to reproduce.

I will check and fix

Touch mode -> Select text. Selecting text less then around 8 characters makes the keyboard appear / disappear. It's also really difficult to select text on iOS (not tested iPadOS), and could do with the OS' built-in method of text highlighting

Yes my own implementation of text copy is far from user friendly you're right.
I need to improve it.
Right now you can still use "View Scrollback Buffer" in order to copy your content.

How do we copy text once highlighted? Tapping it just brings up the keyboard and highlight is lost. Touch holding brings up the menu, but selecting Copy -> Copy Selected doesn't make sense. What should happen here?

Once again you're right.

Does it then copy any text I highlight?

Not yet (but yes it will) : #523

@isontheline isontheline self-assigned this Aug 28, 2022
@isontheline isontheline added the ✨ enhancement New feature or request label Aug 28, 2022
@isontheline isontheline added this to the 20 - Moon milestone Aug 28, 2022
@jarrah31
Copy link
Author

Thank you Arnaud!

macOS feedback:

  • Using the right-click menu to copy and paste text causes the flashing cursor to loose focus. After selecting either copy or paste, I then need to click back on the screen to continue typing.
  • Looking forward to Copy to pasteboard on selection #523 where I can just highlight text and then press middle mouse button to paste. :)

@jarrah31
Copy link
Author

I was curious to see how Termius handles copy/paste, so I launched the app and had a quick play. I must admit, their copy/paste method works really well, and it would be great if WebSSH could emulate it (I presume there's no trademark issues in doing so...)

Basically, you can scroll using touch by default. Touch-holding text causes a magnifying glass to appear to help you position the start of the cursor. An Apple-style "Select, Select All, Paste" menu then appears when you let go. If I press Select it highlights that word and presents draggable anchor points to highlight more text, with a "Copy, Select All, etc" menu appearing each time I stop touching the screen.
image
image
image

@isontheline
Copy link
Owner

Yes Termius team have implemented a better text selection than me (they don't seem to use the native one though).

I will also implement a good one 😅

@isontheline
Copy link
Owner

Copy Paste with the iPadOS is only doable by Scrollback Buffer, when there is no mouse in place.
But this is a real hazzle in my eyes, as the text in scrollback is really small and to copy text is really tough job to do. I would like to have a better way to copy and paste on the ipad.

From @MrFly72 on #762 (comment)

@isontheline isontheline changed the title New Copy/Paste Feedback Copy & Paste improvements Nov 7, 2022
@isontheline isontheline modified the milestones: 20 - Moon, 21 - Penguin Dec 11, 2022
@isontheline
Copy link
Owner

Some improvements of text selection are now available inside the latest beta release https://testflight.apple.com/join/QSrBK59z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants