Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keeps loosing connection #777

Closed
mbierman opened this issue Nov 22, 2022 · 22 comments
Closed

keeps loosing connection #777

mbierman opened this issue Nov 22, 2022 · 22 comments
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@mbierman
Copy link

Bug description

If I am logged in to a machine via WebSSH and I move to other windows for a while and come back the connection looks alive but I can't do anything for quite a long time. It may eventually "come alive". Closing that connection and reopening "fixes" but is tedious.

Screenshots

If applicable, add screenshots to help explain your problem

Steps to reproduce

  1. Login to a machine.
  2. Move focus for a while to another window
  3. Return to WebSSH
  4. Error is thrown

Version 20.4 (1000)

@isontheline
Copy link
Owner

Does network have been paused?

@isontheline isontheline self-assigned this Nov 22, 2022
@isontheline isontheline added the 🐛 bug Something isn't working label Nov 22, 2022
@mbierman
Copy link
Author

No change to the network.

@isontheline
Copy link
Owner

Thanks for your feedback @mbierman I will check

Sometimes it could happen when too many processes are opened and macOS is requiring memory : I'm facing this issue and need to find the root cause

@isontheline isontheline added this to the 20 - Moon milestone Nov 22, 2022
@mbierman
Copy link
Author

Memory doesn't seem to be taxed—but I will keep an eye on that when this happens and see if I can reproduce.

@mbierman
Copy link
Author

mbierman commented Dec 1, 2022

Sorry to be a pain, but any progress? webssh is becoming too unreliable to use since I loose connection in the middle of editing files.

@isontheline
Copy link
Owner

Under iOS and iPadOS there are a lot of rules that Apple run in order to keep your battery level safe.

If you are using macOS, please provide :

  • your operating system version
  • your operating system uptime
  • your operating system free memory

@mbierman
Copy link
Author

mbierman commented Dec 3, 2022

The machine I use most often has no battery. It is a macmini.
macOS 13.0.1 (22A400)
22:26 up 11 days, 3:10, 4 users, load averages: 2.72 2.63 1.93
image

I also have a a macbook pro. I think it happens on this machine too but I don't use it equally so it is hard to say definitively.
1.7 GHz Quad-Core Intel Core i7
13.0.1 (22A400)

I'm not seeing the issue on iOS.

I don't think I have seen this issue on iOS.

@isontheline
Copy link
Owner

That's perfect @mbierman !

Are you seeing an increase since upgrading to Ventura?

I will make my best efforts to resolve this issue

@isontheline
Copy link
Owner

Yet I can't reproduce on MacBook Air macOS 13.0.1

@mbierman
Copy link
Author

mbierman commented Dec 3, 2022

I did not see this issue before Ventura.

@isontheline
Copy link
Owner

isontheline commented Dec 5, 2022

Possible root cause identified : under Ventura (more agressive than before) the WKWebView is reloaded (didNavigationFinish) when the app go to background state but the terminal is in a "zombie" state when coming back to foreground.

If you use tmux you shouldn't see this trouble.

If you don't use tmux, most often the screen will be "dark" (or background color you have choosed). Could you confirm @mbierman ?

I'm searching for a fix.

@isontheline
Copy link
Owner

Hello @mbierman 👋

I can't tell any ETA about this issue but I'm strongly working on it.
Will be shipped with 20.7 (or perhaps 20.6) in a few days.

@mbierman
Copy link
Author

mbierman commented Dec 5, 2022

I appreciate that so much! I will look forward to trying it out.

@isontheline
Copy link
Owner

isontheline commented Dec 7, 2022

A first fix attempt will be released in a few hours.

The fix will be made in two steps :

  1. Reloading the terminal view (prevent locking as you are encountering) when killed by macOS (due to aggressive memory pressure management under Ventura)
  2. Reloading the scrollback buffer in order to scroll the history as usual

The first step will let you to use WebSSH again when kills occur.
The second will try to make the kill "transparent". This second step will be available in a few days.

@mbierman
Copy link
Author

mbierman commented Dec 7, 2022

Fantastic! Thank you and I will update here with any feedback.

@isontheline
Copy link
Owner

You're Welcome @mbierman

Last update 20.6.1011 is available on TestFlight.

TestFlight is however encountering some problems these last hours :
https://developer.apple.com/forums/search/?q=testflight&page=1&sortBy=lastUpdated

@isontheline
Copy link
Owner

@mbierman TestFlight should work now

@isontheline
Copy link
Owner

@mbierman Invitation have been sent

@mbierman
Copy link
Author

Thank you!

@isontheline
Copy link
Owner

Build 1013 now tries to restore the terminal state (as much as it can).

@isontheline isontheline modified the milestones: 20 - Moon, 21 - Penguin Dec 11, 2022
@isontheline
Copy link
Owner

This issue is being pushed to the App Store. Should be available in the next few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants