Inconsistency with tl_iso_product.price.0 translation

[fritzmg]

The original English translation string for tl_iso_product.price.0 is Price & tax class (Price & tax class). However, in many of the other translations, it's just Price.

The following languages use Price:

• da
• de
• fr
• pl
• ru

The following languages use Price & tax class:

• nl
• sl
• tr

Since this translation is also used in the front end, e.g. for the product sorting options of the product filter module, it probably makes sense if the translation is just Price for all languages (including English), as "sort by price and tax class" does not make sense for front end users, since it actually only sorts by price and the tax class isn't typically visibly anyway.

As a side note - the following languages do not have a translation for tl_iso_product.price.0 yet:

• cs
• es
• fa
• fi
• pt_BR

[aschempp]

I wonder why the same label is used in the front end though? That does not really make sense to me, or does it to you?

[fritzmg]

I assume it automatically uses the translation from tl_iso_product.*, since you can add any custom field as a sorting or filter parameter?

[fritzmg]

See ProductFilter implementation:

core/system/modules/isotope/library/Isotope/Module/ProductFilter.php

Lines 391 to 401 in 38b4c2a

	$arrOptions[] = [
	'label' => Format::dcaLabel('tl_iso_product', $field) . ', ' . $asc,
	'value' => $field . ':ASC',
	'default' => ($isDefault && $objSorting->isAscending()) ? '1' : '',
	];
	$arrOptions[] = [
	'label' => Format::dcaLabel('tl_iso_product', $field) . ', ' . $desc,
	'value' => $field . ':DESC',
	'default' => ($isDefault && $objSorting->isDescending()) ? '1' : '',
	];

[fritzmg]

Shouldn't the labels for nl, sl and tr also be adjusted?

[aschempp]

Thats up to the respective translation team (on Transifex).