Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip fallback #2

Open
Showcase-Joz opened this issue Mar 19, 2017 · 3 comments
Open

ip fallback #2

Showcase-Joz opened this issue Mar 19, 2017 · 3 comments

Comments

@Showcase-Joz
Copy link

@needsmorecoffee consider adding navigator.geolocation as a fallback to ip method. some devices are not able to show a location/place name. i am assuming this is down to ip method from mobile devices.

taken from fork updates,

unless you commit them to master
no location on mobile

@ispeakcomputer
Copy link
Owner

I certainly will do that . Thank you for your input on this . I love to hear your criticism. They are very valid points. I plan to rewrite the app again very soon.

@ispeakcomputer
Copy link
Owner

I would also like to add in some exception handling and write this OOP to clean everything up. I am brushing up on Javascript. I plan to dive into this soon.

@Showcase-Joz
Copy link
Author

excellent,

i'd start with this request. i'm in a coffee shop in chesterfield and the ip method is running through the coffee shops router, placing me in barnsley......about 40 miles away :/

simplicity ltd

theme of your addapted repositary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants