Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't download offline files #1993

Closed
1 of 2 tasks
HarelM opened this issue Apr 20, 2024 · 1 comment
Closed
1 of 2 tasks

Can't download offline files #1993

HarelM opened this issue Apr 20, 2024 · 1 comment
Assignees
Labels
bug Critical Needs to be fix ASAP

Comments

@HarelM
Copy link
Member

HarelM commented Apr 20, 2024

What happened?

Application fails to download offline files

What steps will reproduce the bug?

  1. Start offline files download
  2. Fails after 50%

What I expect to happen

Download should succeed

Platform

  • Israel Hiking Map app
  • Israel Hiking Map site in a browser

OS Name and Version

Android 13

Browser Name and Version

N/A

Additional information

This is related to a recent change I made when migrating to github actions where I added magnification and proguard to android build.

The reason I added it was to solve I warning I keep getting when publishing the aab file in play console.
There is cause a runtime issue that is described here:

There are two options here:

  1. Revert changes (which I checked to make sure it solves the issue) and keep the play console warning
  2. Add proguard rules to avoid minify cordova and capacitor plugins and core, the problem with this approach is that the issues we encountered are runtime exceptions, and those are hard to predict and test up front before publishing the app.

Both options aren't great...

@HarelM HarelM added the bug label Apr 20, 2024
@HarelM HarelM self-assigned this Apr 20, 2024
@HarelM HarelM added the Critical Needs to be fix ASAP label Apr 20, 2024
@HarelM HarelM added this to the Next Release milestone Apr 20, 2024
@HarelM
Copy link
Member Author

HarelM commented May 1, 2024

I have decided to revert as an initial step, I'll later on see if the warnings are still in the play console and see what's the easiest way to fix them.

@HarelM HarelM closed this as completed in 5ccf234 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical Needs to be fix ASAP
Projects
None yet
Development

No branches or pull requests

1 participant