Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List the latest comments (no matter the URI) #556

Closed
facundobatista opened this issue Jun 8, 2019 · 8 comments
Closed

List the latest comments (no matter the URI) #556

facundobatista opened this issue Jun 8, 2019 · 8 comments
Labels

Comments

@facundobatista
Copy link
Contributor

I have a blog and I'm using Isso (thanks for this software, is great!!).

I want to implement a section in my blog that should show the latest 10 comments I got in the whole blog, with a link to the original post).

For that, I'd need to list all the comments, not filtering by a specific URI. Of course, not all the comments, the latest N.

Is there a current way of doing this?

If not, I'd propose to extend the API, add a new endpoint "/latest/N" where the N is limit (it's mandatory! it doesn't make sense to get everything).

I would work on adding this new endpoint, but I'd love to get some feedback about this proposal, ideas, etc.

Thanks!!

@jelmer jelmer added the feature label Jun 8, 2019
@jelmer
Copy link
Member

jelmer commented Jun 8, 2019

FWIW That seems like a reasonable feature to have to me.

@facundobatista
Copy link
Contributor Author

A different API design could be to support current / but not making the uri mandatory (however, in that case limit would be).

So, it would be something like: https://commentserver/?limit=10.

What do you think about this one?

@jelmer
Copy link
Member

jelmer commented Jun 8, 2019

I think you should add a separate endpoint, so perhaps something like:

 /all?limit=10

rather than adding it to the root.

@facundobatista
Copy link
Contributor Author

For a separate endpoint, what do you think about /latest? It transmits the idea of time sorting, which is a key feature of this.

@jelmer
Copy link
Member

jelmer commented Jun 8, 2019

/latest seems like a reasonable name for the endpoint.

@Konzertheld
Copy link
Contributor

Konzertheld commented Jul 11, 2019

I would like to see this feature, too. It could propably also be used for a feed of all comments (or at least parts of its code). No hard opinion on the name of the endpoint but I agree it should not be done by calling the existing endpoint with / as the URI, because / does not actually have any comments.

Do you use upvoting here? I would +1 the feature then.

@fluffy-critter
Copy link
Contributor

If this feature gets added, please make it opt-in. I'm using Isso for the comments on my website which includes private posts (which have hard-to-guess URIs) and I don't want just any random person to be able to retrieve the list of all comments on my site.

@facundobatista
Copy link
Contributor Author

Proposed this to fulfill this issue: #610

@jelmer jelmer closed this as completed in 1633d92 Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants