Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin interface uses public-endpoint instead of host when linking to posts #647

Open
Konzertheld opened this issue Apr 30, 2020 · 3 comments
Labels
bug needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed
Milestone

Comments

@Konzertheld
Copy link
Contributor

Konzertheld commented Apr 30, 2020

What the title says. I can't use the links to my posts in the comments lists because they use the wrong base URL. I use public-endpoint as per this workaround: #558 (comment)

So the links are test.site.de/post-slug but should instead be site.de/post-slug as the front site does not run on a subdomain.

Now I am unsure if this is expected behaviour and a consequence of the other bug or a separate bug...

@EchedelleLR
Copy link

I am on the same issue.

@ix5
Copy link
Member

ix5 commented Jan 15, 2021

The main issue is that isso isn't aware of any "host" parameter, it only records a relative uri path component. As such, only the uri component is rendered in the admin interface: admin.html.

I've decided for myself to use full URLs instead of paths, see uri-location-full, but that's not feasible for upstream isso.

You might use the local() interface to access e.g. origin which resolves to the first(?) host you defined in your config - and pass that host to the template via the admin endpoint.

@ix5 ix5 added needs-decision Architectural/Behavioral decision by maintainers needed needs-contributor Someone needs to implement this. Help wanted! labels Dec 26, 2021
@ix5
Copy link
Member

ix5 commented Dec 26, 2021

Related: #566

@ix5 ix5 added the bug label Feb 6, 2022
@ix5 ix5 added this to the 0.13 milestone Feb 13, 2022
@ix5 ix5 modified the milestones: 0.13, 0.14 May 25, 2022
@ix5 ix5 modified the milestones: 0.14, 0.13.1 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-contributor Someone needs to implement this. Help wanted! needs-decision Architectural/Behavioral decision by maintainers needed
Projects
None yet
Development

No branches or pull requests

3 participants