Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize to any kind of polls #76

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Generalize to any kind of polls #76

merged 5 commits into from
Sep 22, 2021

Conversation

luishfonseca
Copy link
Collaborator

No description provided.

@luishfonseca luishfonseca linked an issue Sep 19, 2021 that may be closed by this pull request
Minor Enhancements to Attendance Functionality #54
Open
6 tasks
@luishfonseca luishfonseca changed the title Generalize polls Generalize to any kinda of polls Sep 19, 2021
@luishfonseca luishfonseca mentioned this pull request Sep 19, 2021
Open
6 tasks
@luishfonseca luishfonseca marked this pull request as ready for review September 19, 2021 22:17
RafDevX
RafDevX requested changes Sep 19, 2021
View reviewed changes
Copy link
Member

@RafDevX RafDevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing some tweaks

src/modules/polls.ts Outdated Show resolved Hide resolved
src/modules/polls.ts Outdated Show resolved Hide resolved
src/modules/polls.ts Outdated Show resolved Hide resolved
src/modules/polls.ts Outdated Show resolved Hide resolved
src/modules/polls.ts Show resolved Hide resolved
src/modules/polls.ts Show resolved Hide resolved
src/modules/polls.ts Outdated Show resolved Hide resolved
@RafDevX RafDevX changed the title Generalize to any kinda of polls Generalize to any kind of polls Sep 19, 2021
@RafDevX RafDevX added the enhancement New feature or request label Sep 19, 2021
RafDevX
RafDevX approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@RafDevX RafDevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogotcorreia diogotcorreia merged commit cf8d9bc into v2 Sep 22, 2021
@diogotcorreia diogotcorreia deleted the generalize-polls branch September 22, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogotcorreia diogotcorreia diogotcorreia approved these changes

@RafDevX RafDevX RafDevX approved these changes

Assignees

@luishfonseca luishfonseca

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Enhancements to Attendance Functionality
3 participants
@luishfonseca @diogotcorreia @RafDevX