Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework clientlib permission checks #163

Merged
merged 5 commits into from Apr 1, 2019
Merged

Conversation

stoerr
Copy link
Member

@stoerr stoerr commented Apr 1, 2019

The client library sling console plugin now prints for the impersonation user:

  • informational message what client libraries are unreadable
  • errors when a client library is readable but one of it's elements is not
  • errors when a client library references unreadable client libraries or files
  • errors when something is referenced from a client library but not present in JCR

@stoerr stoerr force-pushed the feature/CMP-60-clientlibconsole branch from 1845984 to 4893b80 Compare April 1, 2019 13:02
@stoerr stoerr requested a review from ist-rw April 1, 2019 13:03
@stoerr
Copy link
Member Author

stoerr commented Apr 1, 2019

BTW: there are the following broken references discovered by the checker. I didn't fix that so far, since I'm not sure whether these are unnecessary since nobody missed them so far:
( http://localhost:9090/system/console/clientlibs?type=all&lib=&impersonate=admin )

ERROR: can't find element jslibs/bootstrap/3.3.5/js/bootstrap.min.js of resource folder /apps/composum/prototype/themes/solid/clientlib/body/js
ERROR: can't find element jslibs/bootstrap/3.3.5/js/bootstrap.min.js of resource folder /apps/composum/prototype/themes/solid/clientlib/body/js
ERROR: can't find element composum/pages/components/clientlibs/page of resource folder /apps/composum/prototype/pages/documentation/clientlibs/page/css
ERROR: can't find element composum/pages/components/clientlibs/page/body of resource folder /apps/composum/prototype/pages/documentation/clientlibs/page/body/js
ERROR: can't find element composum/pages/components/clientlibs/page/body of resource folder /apps/composum/prototype/pages/documentation/clientlibs/page/body/js
ERROR: can't find element fonts/awesome/4.6.1/css/font-awesome.min.css of resource folder /apps/composum/prototype/pages/documentation/clientlibs/page/css/fonts
ERROR: can't find element composum/nodes/browser/js/nodes.js of resource folder /libs/composum/assets/manager/clientlibs/manager/js
ERROR: can't find element fonts/awesome/4.6.3/css/font-awesome.css of resource folder /libs/composum/pages/wiki/clientlibs/page/css/fonts
ERROR: can't find element composum/nodes/console/page/js/console.js of resource folder /libs/composum/nodes/console/clientlibs/codeeditor/js

@ist-rw ist-rw merged commit 361b192 into develop Apr 1, 2019
@stoerr stoerr deleted the feature/CMP-60-clientlibconsole branch April 2, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants