Added support for precompiled scripts (SLING-9207) #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your work! That needs many structural changes and has also too many conflicts now. It'll likely also conflict with the special AEM repackaging that has been introduced, and the startup time of Nodes is also only seconds in my experience. So I'm afraid that we don't have the time to include that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for precompiled scripts, based on the work from SLING-9207. In order for Composum to work with these changes, the modules have to be deployed on a Sling instance which has
org.apache.sling.servlets.resolver>= 2.7.0 andorg.apache.sling.scripting.core>= 2.3.0.A demo of this can be checked out at https://github.com/raducotescu/adaptTo2020-demo/tree/master/precompiled-composum. A video accompanying this demo is also available at https://www.youtube.com/watch?v=5RNE-vRCNug&t=277.
More details about the functionality are available at https://github.com/apache/sling-org-apache-sling-servlets-resolver.