Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for option 2 #6

Open
jforcina20 opened this issue Feb 8, 2022 · 0 comments
Open

Feedback for option 2 #6

jforcina20 opened this issue Feb 8, 2022 · 0 comments

Comments

@jforcina20
Copy link
Contributor

What worked well

This option meets all the requirements of the assignment. The page number input works flawlessly and returns the correct data.

What can be improved

When both the search term and the page number values are changed, the API is called twice. Add a setTimeout so the element will wait for both new values before starting the fetch.

Next steps

I think this is the code we should base our final element on. I think we'll create a new repo to add this code to and paste in the additional options. We'll then clone this new repo onto our local machines to work on the lab going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant