Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependencies to support ESLint v7 #5

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

IvanGoncharov
Copy link
Contributor

Fixes warning I have during npm install:

warning " > eslint-plugin-istanbul@0.1.1" has incorrect peer dependency "eslint@^6.0.0".

@coreyfarrell
Copy link
Member

Thank you for the contribution. Would you mind removing everything except the peerDependency update? This module still supports being tested on Node.js 8 so the devDependency updates cannot be merged yet. Dropping Node.js 8 support from istanbuljs modules is on hold until after Babel 8 is released (the plan is for our next semver-major to upgrade Babel).

@IvanGoncharov
Copy link
Contributor Author

@coreyfarrell Done ✅

@coreyfarrell coreyfarrell merged commit 7de0a0a into istanbuljs:master Jun 29, 2020
@coreyfarrell
Copy link
Member

Thanks, this is merged and released as eslint-plugin-istanbul@0.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants