Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files key to package.json #17

Merged
merged 1 commit into from
Jan 29, 2017

Conversation

existentialism
Copy link
Contributor

No description provided.

@yahoocla
Copy link

yahoocla commented Dec 9, 2016

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yahoocla
Copy link

yahoocla commented Dec 9, 2016

CLA is valid!

@bcoe
Copy link
Contributor

bcoe commented Jan 17, 2017

@wtgtybhertgeghgtwtg @existentialism sorry for the slow reply! I'd love to help shrink your package size.

rather than adding .nyc_output to the .gitignore, let's add a files stanza that only includes the necessary files -- that way we can exclude tests, etc. as well.

@existentialism existentialism changed the title Add nyc_output to npmignore Add files key to package.json Jan 17, 2017
@existentialism
Copy link
Contributor Author

@bcoe files sounds good to me. Updated!

@kentcdodds
Copy link

ping :)

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcoe anything blocking this one?

@JaKXz
Copy link
Contributor

JaKXz commented Jan 29, 2017

@existentialism in fact I'll just remove the .npmignore file while we're at it.

@bcoe
Copy link
Contributor

bcoe commented Jan 29, 2017

@JaKXz no, just me being behind on OSS :) want to go ahead and land it.

@JaKXz JaKXz merged commit 141f801 into istanbuljs-archived-repos:master Jan 29, 2017
@JaKXz
Copy link
Contributor

JaKXz commented Jan 29, 2017

+ istanbul-reports@1.0.1 published!

@existentialism existentialism deleted the patch-1 branch January 30, 2017 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants