Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #132 add additional patterns to default excludes #133

Merged
merged 1 commit into from Feb 13, 2018

Conversation

mojavelinux
Copy link
Collaborator

  • exclude test folder inside each package in a monorepo
  • exclude -test.js suffix

- exclude test folder inside each package in a monorepo
- exclude -test.js suffix
@coveralls
Copy link

coveralls commented Jan 7, 2018

Coverage Status

Coverage increased (+0.4%) to 88.554% when pulling 3d272ee on mojavelinux:issue-132-excludes into 45936de on istanbuljs:master.

@mojavelinux
Copy link
Collaborator Author

It looks like tests are failing on Windows on Node 4 for reasons unrelated to this PR.

@mojavelinux
Copy link
Collaborator Author

Is this good to merge?

Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Unfortunately I don't have the cycles atm to merge/release this.

@mojavelinux
Copy link
Collaborator Author

👍

@JaKXz JaKXz added the triaged label Jan 16, 2018
@bcoe bcoe merged commit 4cedf63 into istanbuljs:master Feb 13, 2018
@bcoe
Copy link
Member

bcoe commented Feb 13, 2018

@mojavelinux ❤️ it.

@mojavelinux mojavelinux deleted the issue-132-excludes branch February 14, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants