Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to exclude files on writing reports #275

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Add support to exclude files on writing reports #275

merged 1 commit into from
Jan 21, 2019

Conversation

henriquemotaesteves
Copy link
Contributor

This pull request is an attempt to close the issue istanbuljs/nyc#956.

JaKXz
JaKXz previously requested changes Jan 18, 2019
View reviewed changes
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick in the code, but I think this makes sense in general, that the report files respect the files excluded from instrumentation

packages/istanbul-api/test/reporter.test.js Outdated Show resolved Hide resolved
@JaKXz
Copy link
Member

JaKXz commented Jan 21, 2019

@coreyfarrell I think this makes sense as a non-breaking feature, but I'll leave that call to you :)

coreyfarrell
coreyfarrell requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small detail but it's important for modules we directly use to be listed directly in package.json. Once that's addressed I can approve this.

packages/istanbul-api/lib/reporter.js Show resolved Hide resolved
@JaKXz JaKXz merged commit 752be13 into istanbuljs:master Jan 21, 2019
@henriquemotaesteves henriquemotaesteves mentioned this pull request Jan 22, 2019
Closed
@henriquemotaesteves henriquemotaesteves mentioned this pull request Jan 31, 2019
Merged
@StoneCypher StoneCypher mentioned this pull request May 6, 2019
Closed
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyfarrell coreyfarrell coreyfarrell approved these changes

@JaKXz JaKXz JaKXz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henriquemotaesteves @JaKXz @coreyfarrell