Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ignore babel.config.js. #279

Merged
merged 1 commit into from Jan 21, 2019
Merged

feat: Ignore babel.config.js. #279

merged 1 commit into from Jan 21, 2019

Conversation

coreyfarrell
Copy link
Member

No description provided.

JaKXz
JaKXz reviewed Jan 21, 2019
View reviewed changes
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be optimistic and ignore *.config.js? Probably not eh?

@coreyfarrell
Copy link
Member Author

Should we be optimistic and ignore *.config.js? Probably not eh?

If you want I can add other 'well known' config filenames but I don't think it's appropriate to ignore *.config.js.

@JaKXz JaKXz merged commit 24af6eb into istanbuljs:master Jan 21, 2019
@coreyfarrell coreyfarrell deleted the ignore-babel-config branch March 6, 2019 00:38
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz left review comments

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coreyfarrell @JaKXz