fix: Remove **/node_modules/** from defaultExclude.
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is appended to the `exclude` list unless excludeNodeModules is disabled. Removing from the default list makes it easier to use excludeNodeModules as you no longer need to reset the `exclude` array to get coverage of node_modules. Fixes #347
coreyfarrell
commented
Apr 2, 2019
| @@ -57,7 +57,7 @@ class TestExclude { | |||
| this.excludeNodeModules && | |||
| !this.exclude.includes('**/node_modules/**') | |||
| ) { | |||
| this.exclude.push('**/node_modules/**'); | |||
| this.exclude = this.exclude.concat('**/node_modules/**'); | |||
There was a problem hiding this comment.
This may appear unrelated but now this.exclude === exportFunc.defaultExclude which does not contain **/node_modules/** so without this shallow copy we would append the default list (this was caught by the tests). Previously we were appending any opts.exclude that did not include **/node_modules/**, though that was unlikely to cause any real problem.
|
CC @hershmire just so you know. |
bcoe
approved these changes
Apr 3, 2019
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is appended to the
excludelist unless excludeNodeModules isdisabled. Removing from the default list makes it easier to use
excludeNodeModules as you no longer need to reset the
excludearray toget coverage of node_modules.
Fixes #347