Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sorting #369

Merged
merged 1 commit into from Apr 17, 2019
Merged

fix sorting #369

merged 1 commit into from Apr 17, 2019

Conversation

richardlau
Copy link
Contributor

#289 broke sorting as it removed the assignment to cols which is referenced later on

In a web browser loading the html report gives the following in the web console:

TypeError: cols is undefined[Learn More] sorter.js:62:13
    loadRowData https://coverage.nodejs.org/coverage-09cdc3782488d2e6/sorter.js:62
    loadData https://coverage.nodejs.org/coverage-09cdc3782488d2e6/sorter.js:77
    addSorting https://coverage.nodejs.org/coverage-09cdc3782488d2e6/sorter.js:164

cc @Trott

@coreyfarrell coreyfarrell merged commit 28f61de into istanbuljs:master Apr 17, 2019
@coreyfarrell
Copy link
Member

@richardlau thanks for the patch, merged and published to istanbul-reports@2.2.3.

@richardlau richardlau deleted the patch-1 branch November 7, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants