feat: Convert to async API #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: MapStore#transformCoverage is now async and returns a the coverage data only. The `sourceFinder` method is now async and provided directly on the `MapStore` instance.
Should be fine, the only things jest needs to be sync is source transformation and source maps for errors. Coverage calculation is perfectly fine async 👍 |
|
What do you mean source maps for errors? You mean production of source maps during the transformation or something else? |
|
Nothing to do with istanbul, I just mentioned which parts related to sourcemaps Jest needs to have sync. (when running tests we might get errors that we wanna map through sourcemaps) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: MapStore#transformCoverage is now async and returns a
the coverage data only. The
sourceFindermethod is now async andprovided directly on the
MapStoreinstance.CC @SimenB I know you use this API in jest, any objections? We're not yet upgrading to
source-map@0.7.xbut this will make that upgrade possible without further changes to the public API. Moving thesourceFindermethod from the result of transformCoverage to the class itself is not strictly needed but just seems correct.